Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start of status screen and add new picked up button #520

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

KiOui
Copy link
Owner

@KiOui KiOui commented Nov 12, 2023

Closes #519

@KiOui KiOui added the feature New or improved functionality. label Nov 12, 2023
@KiOui KiOui self-assigned this Nov 12, 2023
@KiOui KiOui marked this pull request as draft November 13, 2023 08:14
@KiOui KiOui force-pushed the feature/status-screen branch from 70304c9 to 76be4b4 Compare March 10, 2024 09:08
@KiOui KiOui marked this pull request as ready for review March 10, 2024 09:58
@KiOui KiOui requested a review from JobDoesburg March 10, 2024 10:12
Copy link
Collaborator

@JobDoesburg JobDoesburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe we should put the status screen in a separate app though. I think that would help keep the orders app small (its already a bit too large)

@KiOui KiOui force-pushed the feature/status-screen branch from d840a5b to 460ed23 Compare March 15, 2024 15:55
@KiOui KiOui requested a review from JobDoesburg March 18, 2024 19:02
@KiOui
Copy link
Owner Author

KiOui commented Apr 9, 2024

Shall I merge this?

@JobDoesburg
Copy link
Collaborator

@KiOui let's separate the status screen

@KiOui KiOui force-pushed the feature/status-screen branch from c51f9f1 to 566d3ac Compare April 28, 2024 19:59
@KiOui
Copy link
Owner Author

KiOui commented Apr 28, 2024

Updated!

from status_screen import views

urlpatterns = [
path("<shift:shift>/", views.StatusScreen.as_view(), name="status"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add a path with a venue, that automatically redirects to the currently open shift in that venue.

@KiOui KiOui force-pushed the feature/status-screen branch 3 times, most recently from abda1ec to 6b8cd43 Compare June 3, 2024 16:58
@KiOui KiOui force-pushed the feature/status-screen branch from 6b8cd43 to fe199fb Compare June 3, 2024 17:06
@JobDoesburg JobDoesburg merged commit b632114 into master Jun 3, 2024
3 checks passed
@JobDoesburg JobDoesburg deleted the feature/status-screen branch June 3, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New or improved functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make McDonald's status screen
2 participants