Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yivi integration for 18+ check #504

Merged
merged 13 commits into from
Oct 3, 2023
Merged

Yivi integration for 18+ check #504

merged 13 commits into from
Oct 3, 2023

Conversation

KiOui
Copy link
Owner

@KiOui KiOui commented Sep 18, 2023 •
edited
Loading

This PR adds Yivi integration for an 18+ check.

An abstract yivi application is added that can do attribute verification on arbitrary attributes. The age application that is added uses the functionality of the yivi application to verify the age of a user.

@KiOui KiOui self-assigned this Sep 18, 2023
@KiOui KiOui marked this pull request as draft September 18, 2023 20:53
@KiOui KiOui added the feature New or improved functionality. label Sep 18, 2023
@KiOui KiOui changed the title Feature/18+check Yivi integration for 18+ check Sep 18, 2023
@KiOui KiOui requested a review from JobDoesburg September 18, 2023 20:55
@KiOui KiOui marked this pull request as ready for review September 19, 2023 19:51
JobDoesburg
JobDoesburg approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@JobDoesburg JobDoesburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but maybe add a field so we can verify if the age registration was done via yivi or manually

@KiOui
Copy link
Owner Author

KiOui commented Oct 2, 2023

Looks good, but maybe add a field so we can verify if the age registration was done via yivi or manually

Done!

@JobDoesburg JobDoesburg merged commit ba1848c into master Oct 3, 2023
2 checks passed
@JobDoesburg JobDoesburg deleted the feature/18+check branch October 3, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JobDoesburg JobDoesburg JobDoesburg approved these changes

Assignees

@KiOui KiOui

Labels
feature New or improved functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KiOui @JobDoesburg