Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite VueJS to use script module type #497

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

KiOui
Copy link
Owner

@KiOui KiOui commented Sep 6, 2023

This PR rewrites all VueJS initializers to use the createApp function with the module script syntax. VueJS is also updated to the most recent version 3.x.

Two things we need to take into account in the future:

  • Custom delimiters <% and %> are no longer supported, I replaced them in favor of ${ and }$.
  • Because <script type="module"> blocks do not declare variables in a global scope, I used window.[variable] to declare global variables.

To test, open the browser console and run through all the interactive components of TOSTI (so the Shifts and the Thaliedje player).

Closes #491

@KiOui KiOui added the chore No bugfix and no functionality. label Sep 6, 2023
@KiOui KiOui self-assigned this Sep 6, 2023
@KiOui KiOui marked this pull request as draft September 6, 2023 08:20
@KiOui KiOui marked this pull request as ready for review September 6, 2023 09:53
@KiOui KiOui requested review from nvoers and JobDoesburg September 6, 2023 09:53
Copy link
Collaborator

@JobDoesburg JobDoesburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is the right time to move the JS to (static) JS files and include those (by loading them in a js post body block), instead of putting them in html templates

@KiOui
Copy link
Owner Author

KiOui commented Sep 7, 2023

Maybe this is the right time to move the JS to (static) JS files and include those (by loading them in a js post body block), instead of putting them in html templates

Let's make an issue for that 😄

@KiOui KiOui merged commit 1af9673 into master Sep 7, 2023
@KiOui KiOui deleted the chore/use-script-module branch September 7, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore No bugfix and no functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite VueJS javascript such that we use script type module
2 participants