Rewrite VueJS to use script module type #497
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites all VueJS initializers to use the
createApp
function with themodule
script syntax. VueJS is also updated to the most recent version 3.x.Two things we need to take into account in the future:
<%
and%>
are no longer supported, I replaced them in favor of${
and}$
.<script type="module">
blocks do not declare variables in a global scope, I usedwindow.[variable]
to declare global variables.To test, open the browser console and run through all the interactive components of TOSTI (so the Shifts and the Thaliedje player).
Closes #491