-
Notifications
You must be signed in to change notification settings - Fork 937
Implement GL_EXT_long_vector #4132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3e82d38 to
ba601af
Compare
dnovillo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine overall.
- For coopvecNV, I think we allow conversions from/to vector types. Is this still true? Maybe add a test for this.
- I did not see a test for GL_EXT_buffer_reference for long vectors. That's allowed, I think?
- long vectors in uniform and buffer blocks are not allowed, right? I don't think we are validating this (or even testing?)
layout(constant_id = 0) const uint N = 5;
layout(set=0, binding=0, std140) uniform UBO {
vector<float, N> v; // I think this should be invalid?
};
Yes, conversions are allowed. There's some testing for this in spv.longVector.comp:testfuncs() (including parameter passing).
This was missing, I've added it to spv.longVectorStorage.comp.
This is allowed, it's tested in spv.longVectorStorage.comp. I'll push an update shortly. |
dnovillo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. OK to go in as soon as the SPIRV-Tools changes have been submitted to ToT.
dnovillo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. Will submit as soon as the bots finish.
GLSL spec: KhronosGroup/GLSL#297
SPIR-V spec: KhronosGroup/SPIRV-Registry#377