Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glfw submodule to latest #1237

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

SaschaWillems
Copy link
Collaborator

Description

This PR updates the glfw submodule to the latest release. We haven't updated this in ages, which seems to cause issues for some newer linux distros.

Did two full batch runs (debug and release build) in Windows to make sure changes don't cause any issues.

Fixes #1192

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

@SaschaWillems
Copy link
Collaborator Author

@tomadamatkinson : Clang Tidy Check fails because glfw needs new libraries. Any idea why that needs libraries at all? Doesn't it just check code files? I added new required libs to all steps that require them, but I can't see where those need to be set up for Clang Tidy.

P.S. : I think we need to clean up / streamline CI. So many places that you have to care for when new requirements come in :/

@tomadamatkinson
Copy link
Collaborator

There is a PR which merges v2 with the existing pipeline and removes the Debug builds. That should help.

In terms of these dependencies I think they are now default required by GLFW. You can turn off Wayland builds with a CMake flag. Not sure why Antora needs it... is that not a documentation pass

@SaschaWillems
Copy link
Collaborator Author

Well, the problem is that EVERY CI step that does build samples needs the new libraries. I already added them to all CI steps incl. Antora, but I have no clue how to add them to the Clang Tidy step. It's the last one failing, so I need some help here ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with running examples on Fedora 40 with KDE 6.2
2 participants