-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update glfw submodule to latest #1237
base: main
Are you sure you want to change the base?
Conversation
Old version was 3.3, released over two years ago Fixes KhronosGroup#1192
Weird, but somehow required
@tomadamatkinson : Clang Tidy Check fails because glfw needs new libraries. Any idea why that needs libraries at all? Doesn't it just check code files? I added new required libs to all steps that require them, but I can't see where those need to be set up for Clang Tidy. P.S. : I think we need to clean up / streamline CI. So many places that you have to care for when new requirements come in :/ |
There is a PR which merges v2 with the existing pipeline and removes the Debug builds. That should help. In terms of these dependencies I think they are now default required by GLFW. You can turn off Wayland builds with a CMake flag. Not sure why Antora needs it... is that not a documentation pass |
Well, the problem is that EVERY CI step that does build samples needs the new libraries. I already added them to all CI steps incl. Antora, but I have no clue how to add them to the Clang Tidy step. It's the last one failing, so I need some help here ;) |
Description
This PR updates the glfw submodule to the latest release. We haven't updated this in ages, which seems to cause issues for some newer linux distros.
Did two full batch runs (debug and release build) in Windows to make sure changes don't cause any issues.
Fixes #1192
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batch
command line argument to make sure all samples still work properly