Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTS issue workflow: Only run on main branch #681

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

psalz
Copy link
Contributor

@psalz psalz commented Dec 12, 2024

Changes that are being cherry-picked into an older version of the spec don't need a separate CTS issue, as the CTS targets all versions from SYCL 2020 onward.

Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@psalz
Copy link
Contributor Author

psalz commented Dec 12, 2024

Now that I think about it, we could also just limit the workflow to run only on the main branch - what do you prefer?

@gmlueck
Copy link
Contributor

gmlueck commented Dec 12, 2024

That would probably be easier because we wouldn't need to add the label. There may be times when we merge a PR directly to the "sycl-2020" branch that is not a cherry pick. However, it's probably rare enough that we can just remember to open a CTS issue if necessary.

To avoid creating CTS issues for cherry-picks into older spec revisions,
we limit the workflow to run on the main branch.
@psalz psalz force-pushed the skip-issue-bot-for-cherry-picks branch from a0527de to d2cad3c Compare December 17, 2024 14:02
@psalz psalz changed the title CTS issue workflow: Skip if PR has cherry-pick label CTS issue workflow: Only run on main branch Dec 17, 2024
@psalz psalz removed the cherry-pick label Dec 17, 2024
@psalz
Copy link
Contributor Author

psalz commented Dec 17, 2024

That would probably be easier because we wouldn't need to add the label. There may be times when we merge a PR directly to the "sycl-2020" branch that is not a cherry pick. However, it's probably rare enough that we can just remember to open a CTS issue if necessary.

Ok, done!

@psalz psalz merged commit a4d9bb9 into main Dec 18, 2024
3 checks passed
@psalz psalz deleted the skip-issue-bot-for-cherry-picks branch December 18, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants