Check forbidden kernel constructs in constant evaluated context #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keryell
force-pushed
the
ronan/sycl-pr-388
branch
from
0266d6d
to
8f5219d
Compare
There are a lot of restrictions for kernel code, except when present in a constant evaluated context. This is a test corresponding to the specification clarification introduced by PR KhronosGroup/SYCL-Docs#388
keryell
force-pushed
the
ronan/sycl-pr-388
branch
from
8f5219d
to
b3ec4b2
Compare
gmlueck
reviewed
Oct 31, 2024
| // through forbidden function pointer which is skipped by the if | ||
| // constexpr. | ||
| auto* p = f; | ||
| auto other = p(5) + f(6); |
There was a problem hiding this comment.
I think that this part does not test a feature used in a manifestly constant evaluated expression.
Rather, I think this is testing that you can use forbidden C++ features in a discarded statement. We did not make this legal in KhronosGroup/SYCL-Docs#388. Potentially, we could consider making this legal, but that would require a separate change to the spec.
There was a problem hiding this comment.
I have allowed "discarded statements" in KhronosGroup/SYCL-Docs@966a051 (#388)
bader
reviewed
Nov 14, 2024
|
KhronosGroup/SYCL-Docs#388 was approved to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of restrictions for kernel code, except when present in a constant evaluated context.
This is a test corresponding to the specification clarification introduced by PR KhronosGroup/SYCL-Docs#388