-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Updates - 'o' to toggle options dialog, smaller 'default' notification, color/layout tweaks, ^L to redraw screen #15
base: master
Are you sure you want to change the base?
Conversation
…xplicit 'default' label
…ByPaddingToLength instead
…elow the option list
…ts position to below the label
…at right now the settings menus don't work properly when options are disabled. (Though that IS the case with the 'stock' pacmixer as well. Will look into it regardless.)
…ad been the opposite of what you'd expect)
…orcing options to turn on, in that case)
Hey, thank you for taking interest in the project and sorry for such a late response! Now, onto the point :-]. I have not looked at the code yet, but I'll comment on the changes you described and how I think about them.
FYI: The ongoing development of |
No worries! Only so many hours in the day, etc. I shall comment on a couple of your comments!
Anyway, no worries re: development! I've got a long list of personal projects on hold, so I get it. I'll look over this stuff again more thoroughly when I'm back, though! Thanks, |
These are a whole bunch of tweaks to how pacmixer's TUI looks; mostly it's just layout/coloring changes, though I've also added in a new key (to toggle the options selections), and fixed a bug. I'm sure that much of this is down to personal preference, re: the layout, so if you like some of these but not all, I'd be happy to pull it apart a bit and get a smaller pull request together.
Anyway, here's what I've added to the project's changelog:
o
keybinding to toggle display of control options.Most of what I changed is apparent from a simple screenshot, so here's how it looks without the options dialogs showing:
... and here it is with the options dialogs:
As I say, personally I like how my tweaked version looks (and it's closer to how alsamixer looks), but I'd certainly understand if there's lots of bits in here that you don't actually want to merge.
Thanks for the app, btw! I'd always felt that not having an alsamixeralike for PulseAudio was one of its biggest weaknesses, so I was thrilled to stumble upon this.