Fixes #32835 - Add RHSM and content URL as info providers #9413

ekohl · 2021-06-18T10:39:52Z

This introduces two Smart Proxy extension methods and exposes them as info providers. This allows clients to use the ENC API to (re)configure subscription-manager.

First of all, this implements logic to determine the RHSM URL. This is constructed by looking at Pulp. While this is really the wrong way, there is currently no alternative. (I started https://github.com/ekohl/smart_proxy_rhsm a while back and that could solve it - another is to bolt it onto the Pulp module).

Ideally this would be exposed as a setting as well. There is a plan to align everything on port 443. If the Smart Proxy exposes a setting, Katello doesn't need to guess and a smooth migration can be realized.

This all becomes more important when the host subscription RPM is phased out.

Then it also introduces pulp_content_url which is already a setting that's exposed via the Smart Proxy Pulp feature. This is also used in the various places where it's needed.

It does highlight a missing setting for pulp_ansible content. Again, Katello should not have to guess URLs but discover it from the infrastructure.

Another potential use case that this allows is using REX to move a host from one content source to another.

Currently a draft since I have not verified this at all. However, I did want to link it and share it. What's also probably missing is provisioning macros.

theforeman-bot · 2021-06-18T10:40:29Z

Issues: #32835

ekohl

I'm not sure if I can really finish this, but this is IMHO important for our enterprise readiness meetings that we've been having. There's also some features that are starting to depend on this information being present (and correct).

Host registration
Removal of the registration RPM
Aligning RHSM on port 443 for all services

app/lib/katello/resources/registry.rb

app/models/katello/concerns/smart_proxy_extensions.rb

ekohl · 2021-06-18T10:53:18Z

app/models/katello/repository.rb

      elsif ansible_collection?
-        "#{scheme}://#{pulp_uri.host.downcase}/pulp_ansible/galaxy/#{relative_path}/api"
+        pulp_uri.path = "/pulp_ansible/galaxy/#{relative_path}/api"


This also needs to be exposed as a setting by smart_proxy_pulp

ekohl · 2021-06-21T12:20:40Z

Related PR: #9417

ekohl · 2021-07-09T17:26:43Z

That has been merged. I'll rebase this on #9450 once that's been merged.

jturel · 2021-07-26T13:15:43Z

9450 is merged! please drop this out of Draft state when it's ready for review :)

jturel · 2021-08-10T13:11:50Z

@ekohl this is on our board as Ready for Review but I'm gonna move it to our backlog until it's out of draft state. Do you intend to have this ready for 4.2?

ekohl · 2021-09-07T12:02:50Z

I'd love to, but I can't promise anything. Recently theforeman/smart_proxy_pulp@b6582ef was introduced in smart_proxy_pulp so at least the prerequisites are merged. However, my current priority is dealing with the Puppet extraction. I'd appreciate it if someone else could take over.

cc @wbclark

jturel · 2022-01-05T19:09:25Z

Should this be closed / backlogged until someone can address it or it's explicitly required?

ekohl · 2022-01-06T13:53:26Z

Given a lot of the related work has been merged already, this is now actually quite trivial. I must admit I haven't tested it since I don't have a development environment, but it should be quite easy. It's exposed in /api/hosts/:id/enc. If a content source is assigned to it, the URLs should be present.

The other (unrelated work) will be submitted as a separate PR.

ekohl · 2022-01-06T14:00:57Z

The other (unrelated work) will be submitted as a separate PR.

#9878

jturel · 2022-01-06T16:18:12Z

Found this while testing:

16:15:42 rails.1   | 2022-01-06T16:15:42 [I|app|b8c7adba] Started GET "/api/v2/hosts/4/enc" for 127.0.0.1 at 2022-01-06 16:15:42 +0000
16:15:42 rails.1   | 2022-01-06T16:15:42 [I|app|b8c7adba] Processing by Api::V2::HostsController#enc as JSON
16:15:42 rails.1   | 2022-01-06T16:15:42 [I|app|b8c7adba]   Parameters: {"apiv"=>"v2", "id"=>"4"}
16:15:42 rails.1   | 2022-01-06T16:15:42 [I|app|b8c7adba] Authorized user admin(Admin User)
16:15:42 rails.1   | 2022-01-06T16:15:42 [W|app|b8c7adba] Action failed
16:15:42 rails.1   | 2022-01-06T16:15:42 [I|app|b8c7adba] Backtrace for 'Action failed' error (ActiveModel::MissingAttributeError): can't write unknown attribute `rhsm_url`
16:15:42 rails.1   |  b8c7adba | /home/vagrant/foreman/.vendor/ruby/2.7.0/gems/activemodel-6.0.3.7/lib/active_model/attribute.rb:206:in `with_value_from_database'
16:15:42 rails.1   |  b8c7adba | /home/vagrant/foreman/.vendor/ruby/2.7.0/gems/activemodel-6.0.3.7/lib/active_model/attribute_set.rb:49:in `write_from_user'
16:15:42 rails.1   |  b8c7adba | /home/vagrant/foreman/.vendor/ruby/2.7.0/gems/activerecord-6.0.3.7/lib/active_record/attribute_methods/write.rb:43:in `_write_attribute'
16:15:42 rails.1   |  b8c7adba | /home/vagrant/foreman/.vendor/ruby/2.7.0/gems/activerecord-6.0.3.7/lib/active_record/attribute_methods/write.rb:36:in `write_attribute'
16:15:42 rails.1   |  b8c7adba | /home/vagrant/foreman/.vendor/ruby/2.7.0/gems/activerecord-6.0.3.7/lib/active_record/attribute_methods.rb:337:in `[]='
16:15:42 rails.1   |  b8c7adba | /home/vagrant/katello/app/models/katello/host/info_provider.rb:21:in `host_info'
16:15:42 rails.1   |  b8c7adba | /home/vagrant/foreman/app/models/concerns/host_info_extensions.rb:27:in `block in info'
16:15:42 rails.1   |  b8c7adba | /home/vagrant/foreman/app/models/concerns/host_info_extensions.rb:25:in `each'
16:15:42 rails.1   |  b8c7adba | /home/vagrant/foreman/app/models/concerns/host_info_extensions.rb:25:in `info'
16:15:42 rails.1   |  b8c7adba | /home/vagrant/foreman/app/controllers/api/v2/hosts_controller.rb:182:in `enc'

ekohl · 2022-01-06T16:22:13Z

Oh that's my bad. They should be parameters rather than top level. Updated now.

app/models/katello/host/info_provider.rb

This exposes the RHSM and content URL as info providers. This allows clients to use the ENC API to (re)configure subscription-manager. This all becomes more important when the host subscription RPM is phased out.

jturel · 2022-01-06T17:00:40Z

app/models/katello/host/info_provider.rb

@@ -16,6 +16,15 @@ def host_info
        if host.content_facet.present?
          info['parameters']['kickstart_repository'] = host.content_facet.kickstart_repository.try(:label)
        end
+
+        if (rhsm_url = host.content_source&.rhsm_url)


I learned that simply registering a content host directly to the server does not establish a content source and so these won't be set. Is that compatible with how you see this being used, or should they get the values from the default smart proxy at that point? Or is it a bug that content_source is nil in that scenario?

I would consider that a bug but I'm not sure how others see it. IMHO every host that has content should have a content_source assigned. Otherwise you always need to remember to do host.content_source || pulp3_primary.

It also means that #9780 may be based on an incorrect assumption and currently can't be used to reconfigure if the host is assigned to the primary.

#9780 works OK. I can create an issue to track that unless you want to dive into it on this PR

jturel · 2022-01-24T16:51:27Z

@ekohl I don't think this needs to be a draft any longer!

ekohl · 2022-01-24T17:16:52Z

Then I'd like it if this was merged.

jturel · 2022-01-24T17:18:20Z

Just realized the katello tests failed but can't see the build any longer. running again.

[test katello]

theforeman-bot added Needs testing Not yet reviewed labels Jun 18, 2021

ekohl mentioned this pull request Jun 18, 2021

Fixes #32678 - katello_ca_consumer in registration template theforeman/foreman#8563

Merged

ekohl commented Jun 18, 2021

View reviewed changes

ekohl force-pushed the 32835-rhsm-pulp-info-providers branch from 6fa02c5 to a058777 Compare January 6, 2022 13:51

ekohl mentioned this pull request Jan 6, 2022

Align on pulp_content_url #9878

Draft

ekohl force-pushed the 32835-rhsm-pulp-info-providers branch from a058777 to 2894bd9 Compare January 6, 2022 16:21

jturel reviewed Jan 6, 2022

View reviewed changes

app/models/katello/host/info_provider.rb Outdated Show resolved Hide resolved

Fixes #32835 - Add RHSM and content URL as info providers

6b31eee

This exposes the RHSM and content URL as info providers. This allows clients to use the ENC API to (re)configure subscription-manager. This all becomes more important when the host subscription RPM is phased out.

ekohl force-pushed the 32835-rhsm-pulp-info-providers branch from 2894bd9 to 6b31eee Compare January 6, 2022 16:41

jturel reviewed Jan 6, 2022

View reviewed changes

ekohl marked this pull request as ready for review January 24, 2022 17:16

jturel self-assigned this Jan 24, 2022

jturel approved these changes Jan 24, 2022

View reviewed changes

jturel merged commit f3daacd into Katello:master Jan 24, 2022

ekohl deleted the 32835-rhsm-pulp-info-providers branch January 24, 2022 18:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #32835 - Add RHSM and content URL as info providers #9413

Fixes #32835 - Add RHSM and content URL as info providers #9413

ekohl commented Jun 18, 2021

theforeman-bot commented Jun 18, 2021

ekohl left a comment

ekohl Jun 18, 2021

ekohl commented Jun 21, 2021

ekohl commented Jul 9, 2021

jturel commented Jul 26, 2021

jturel commented Aug 10, 2021

ekohl commented Sep 7, 2021

jturel commented Jan 5, 2022

ekohl commented Jan 6, 2022

ekohl commented Jan 6, 2022

jturel commented Jan 6, 2022

ekohl commented Jan 6, 2022

jturel Jan 6, 2022

ekohl Jan 6, 2022

jturel Jan 24, 2022

jturel commented Jan 24, 2022

ekohl commented Jan 24, 2022

jturel commented Jan 24, 2022

Fixes #32835 - Add RHSM and content URL as info providers #9413

Fixes #32835 - Add RHSM and content URL as info providers #9413

Conversation

ekohl commented Jun 18, 2021

theforeman-bot commented Jun 18, 2021

ekohl left a comment

Choose a reason for hiding this comment

ekohl Jun 18, 2021

Choose a reason for hiding this comment

ekohl commented Jun 21, 2021

ekohl commented Jul 9, 2021

jturel commented Jul 26, 2021

jturel commented Aug 10, 2021

ekohl commented Sep 7, 2021

jturel commented Jan 5, 2022

ekohl commented Jan 6, 2022

ekohl commented Jan 6, 2022

jturel commented Jan 6, 2022

ekohl commented Jan 6, 2022

jturel Jan 6, 2022

Choose a reason for hiding this comment

ekohl Jan 6, 2022

Choose a reason for hiding this comment

jturel Jan 24, 2022

Choose a reason for hiding this comment

jturel commented Jan 24, 2022

ekohl commented Jan 24, 2022

jturel commented Jan 24, 2022