Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Make log height dynamic #1771

Merged
merged 1 commit into from
May 10, 2023
Merged

Make log height dynamic #1771

merged 1 commit into from
May 10, 2023

Conversation

mmuzikar
Copy link
Contributor

@mmuzikar mmuzikar commented May 9, 2023

Requires patternfly/react-log-viewer#28 to work

Closes 577

@mmuzikar mmuzikar requested a review from a team May 9, 2023 13:05
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care.

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #1771 (0b7a6dc) into main (8c916e7) will decrease coverage by 0.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1771      +/-   ##
==========================================
- Coverage   66.35%   66.05%   -0.31%     
==========================================
  Files          74       75       +1     
  Lines        2158     2180      +22     
  Branches      482      485       +3     
==========================================
+ Hits         1432     1440       +8     
- Misses        682      695      +13     
- Partials       44       45       +1     
Impacted Files Coverage Δ
src/components/Console.tsx 9.52% <ø> (ø)

... and 3 files with indirect coverage changes

@Delawen Delawen added this to the 1.1.0 milestone May 9, 2023
@mmuzikar mmuzikar changed the title Draft: Make log height dynamic Make log height dynamic May 10, 2023
@kahboom kahboom merged commit 0eb26f3 into KaotoIO:main May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants