rollup 관련 의존성 제거 #233
Merged
rollup 관련 의존성 제거 #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add proper board ID handling
…into feature/231-게시물-생성-및-view-개선
There was a problem hiding this comment.
Pull Request Overview
This PR removes the optional dependency on @rollup/rollup-linux-x64-gnu and updates package manager info while also refining various UI elements, navigation flows, and API integrations in board‐related pages.
- Removed rollup dependency and added .cursor to .gitignore to improve environment consistency
- Updated styling units, component layout, and navigation paths across HomePage, BoardRegisterPage, BoardPage, and related components
- Refactored API calls and component logic (e.g. making isAnonymous optional, using FormData, and adjusting modal deletion flows)
Reviewed Changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/HomePage/HomePage.tsx | Added a debug console.log in NoticeComponent and adjusted navigation paths |
| src/pages/HomePage/HomePage.styled.ts | Converted rem-based values to pixel units for styling consistency |
| src/pages/BoardPage/BoardRegisterPage/BoardRegisterPage.tsx | Enhanced board registration UI with a new "question" mode and file input handling; includes a naming suggestion for a parameter |
| src/pages/BoardPage/BoardPostItem.tsx | Added edit/delete options for posts with inline modal handling for deletion |
| src/pages/BoardPage/BoardPage.tsx | Updated deletion flow using a modal; introduced a global variable to store the postId for deletion (which could be improved) |
| src/pages/BoardPage/BoardList.tsx | Improved board filtering and navigation based on the mode (question vs board) and refined assignment logic |
| src/pages/BoardPage/BoardDetailpage/BoardDetailPage.tsx | Adjusted anonymous profile image handling and removed a debug log from the post detail component |
| src/main.tsx | Temporarily commented out React.StrictMode, which should be documented if maintained |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (3)
src/pages/BoardPage/BoardRegisterPage/BoardRegisterPage.tsx:218
- [nitpick] Consider renaming parameter 'i' to 'tagName' for improved clarity in the function signature.
const onHashTagClick = (i: string) => {
src/pages/BoardPage/BoardList.tsx:73
- [nitpick] Refactor the assignment within the render for improved readability and maintainability instead of using inline assignments.
prevId.current !== board.boardId && (prevId.current = board.boardId) && null
src/pages/HomePage/HomePage.styled.ts:7
- [nitpick] Confirm that converting the height from rem to px meets the responsive design requirements, and document any design assumptions.
height: 52px;
| const canManageSpace = authSpaceStore((state) => state.canManageSpace); | ||
|
|
||
| const NoticeComponent = ({ data }: { data: NoticeDetail }) => { | ||
| console.log(data); |
There was a problem hiding this comment.
Remove the console.log statement after debugging to prevent unnecessary log clutter in production.
Suggested change
| console.log(data); |
Comment on lines
+34
to
35
| let _postId = 0; | ||
| const BoardContent = ({ selectedOption, isModalOpen, setIsModalOpen }: BoardContentProps) => { |
There was a problem hiding this comment.
Using a global mutable variable to track the postId for deletion may introduce unexpected issues; consider using component state instead.
Suggested change
| let _postId = 0; | |
| const BoardContent = ({ selectedOption, isModalOpen, setIsModalOpen }: BoardContentProps) => { | |
| const BoardContent = ({ selectedOption, isModalOpen, setIsModalOpen }: BoardContentProps) => { | |
| const [postId, setPostId] = useState<number | null>(null); |
| ); | ||
| } | ||
| }; | ||
| console.log(postDetail.result?.creatorName.indexOf("익명")); |
There was a problem hiding this comment.
Remove the debug console.log statement before merging to production to keep the console output clean.
Suggested change
| console.log(postDetail.result?.creatorName.indexOf("익명")); | |
| // Removed unnecessary console.log statement |
| <App /> | ||
| </QueryProvider> | ||
| </React.StrictMode>, | ||
| // <React.StrictMode> |
There was a problem hiding this comment.
If React.StrictMode is being disabled for a reason, please add a comment or documentation to explain why this decision was made.
Suggested change
| // <React.StrictMode> | |
| // <React.StrictMode> | |
| // React.StrictMode is temporarily disabled to address [specific reason, e.g., compatibility issues, debugging requirements, etc.]. |
Turtle-Hwan
approved these changes
May 7, 2025
Comment on lines
8
to
+14
| import "./index.css"; | ||
| ReactDOM.createRoot(document.getElementById("root")!).render( | ||
| <React.StrictMode> | ||
| <QueryProvider> | ||
| <App /> | ||
| </QueryProvider> | ||
| </React.StrictMode>, | ||
| // <React.StrictMode> | ||
| <QueryProvider> | ||
| <App /> | ||
| </QueryProvider>, | ||
| // </React.StrictMode>, |
Member
|
근데 의존성 없앴는데 왜 이런 에러가 빌드에서 터지는 걸까요 |
….com/KUIT-Space/KUIT-Space-front into infra/delete-rollup-linux-dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
package.json에서 @rollup/rollup-linux-x64-gnu의 optional dependency를 제거하고, .gitignore에 .cursor를 추가하여 개발 환경의 일관성을 높였습니다. 해당 변경 사항은 #232 브랜치를 기반으로 합니다.
PR 유형 및 세부 작업 내용
빌드 부분 혹은 패키지 매니저 수정
파일 혹은 폴더명 수정 (.gitignore)
package.json의 optionalDependencies에서
@rollup/rollup-linux-x64-gnu를 제거하였습니다..gitignore에
.cursor와# cursor를 추가하여 Cursor IDE 관련 파일을 무시하도록 했습니다.packageManager 필드를 최신 yarn 정보로 갱신하였습니다.
test 완료 여부 (선택)
변경 사항이 정상적으로 반영되는지 로컬에서 테스트 완료
작동 스크린샷 (선택)
리뷰 요구사항 (선택)
특이사항 없음