Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/k UI 1599 remove fields #389

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

amirhossein-haerian
Copy link
Contributor

Följande rubriker ska inte längre visas på sidan Inför kursval:

Kontaktperson (KoppsAPI: infoContactName)

Påbyggnad (KoppsAPI: addOn)

Information till forskarstuderande om när kursen ges (KoppsAPI: applicationInfo)

Möjlighet till komplettering (KoppsAPI:possibilityToCompletion)

Möjlighet till plussning (KoppsAPI:possibilityToAddition)

Utrustning (KoppsAPI:requiredEquipment)

Copy link
Contributor Author

@amirhossein-haerian amirhossein-haerian Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that the requiredEquipment field should be removed from the syllabusList as well. Let me know if we should not remove it there.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! I'm not sure but will look into it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said, I believe that you done this correctly, but I added a question to Susanne in the parent Jira issue just to be sure (KUI-1387).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following this up. That would be great for us to be sure.

Copy link
Contributor

@allazis allazis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⭐

Copy link
Contributor

@axelbjo axelbjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amirhossein-haerian amirhossein-haerian merged commit 1fc43df into master Nov 25, 2024
3 checks passed
ghost pushed a commit that referenced this pull request Dec 4, 2024
ghost pushed a commit that referenced this pull request Dec 4, 2024
amirhossein-haerian added a commit that referenced this pull request Jan 24, 2025
amirhossein-haerian added a commit that referenced this pull request Jan 24, 2025
* Revert "Revert "Issues/KUI 1599 remove fields (#389)""

This reverts commit 46faa13.

* Revert "Revert "Issue/k UI 1608 remove fields - literature (#392)""

This reverts commit 39d87b0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants