feat(KUI-1149): redesign of course page #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
July 29, 2024 10:52
… of RoundInformationOneCol)
…ts for RoundInformation
…ecial case for courses without course rounds
ghost
force-pushed
the
issues/KUI-1149-course-page-redesign
branch
from
ae71c71 to
9591d8b
Compare
ghost
changed the title
ghost
marked this pull request as ready for review
ghost
requested review from
belanglos,
amirhossein-haerian,
axelbjo and
allazis
as code owners
amirhossein-haerian
approved these changes
Jul 30, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major redesign of course page. In summary: everything in the right side column has been moved into top of main column.
Some notes:
CoursePage.jsxare more smaller now<RoundInformationOneCol>has been completely rewritten into a new component<RoundInformation>. This include both a lot of design changes and a major refactoring.<RoundInformation>(and its sub-components) are now for displaying info about selected round (ie "the gray box")<RoundSelector>(and sub-components) is for the section where you select semester and rounds (including heading and intro text).