Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparatory courses no longer have 'credits' in title, but 'fup' instead #359

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

axelbjo
Copy link
Contributor

@axelbjo axelbjo commented Jul 23, 2024

Passing the course_level_code property from courseData to determine whether or not a course should have 'credits'/'hp' or 'fup' in the title.

Copy link
Contributor

@amirhossein-haerian amirhossein-haerian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⭐️

@amirhossein-haerian amirhossein-haerian self-requested a review July 23, 2024 13:49
Copy link
Contributor

@karlandindrakryggen karlandindrakryggen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just rename the prop and remove commented-out code

public/js/app/components/CourseTitle.jsx Outdated Show resolved Hide resolved
public/js/app/components/CourseTitle.jsx Outdated Show resolved Hide resolved
@axelbjo axelbjo merged commit b09e7c6 into master Jul 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants