Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues/k UI 1226/antagning button #298

Merged
merged 5 commits into from
Mar 4, 2024
Merged

Issues/k UI 1226/antagning button #298

merged 5 commits into from
Mar 4, 2024

Conversation

vsdkth
Copy link
Contributor

@vsdkth vsdkth commented Feb 28, 2024

No description provided.

@vsdkth vsdkth requested review from belanglos and a user February 28, 2024 15:10
belanglos
belanglos reviewed Mar 4, 2024
View reviewed changes
Copy link
Contributor

@belanglos belanglos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with extracting the component! 👍

Let's discuss this today, because I'd like to understand the logic behind it more.
It looks as if this also conditionally displays the information area around/before the button. Was this requested?

public/js/app/components/RoundApplicationInfo.jsx Show resolved Hide resolved
public/js/app/components/RoundApplicationInfo.jsx Outdated Show resolved Hide resolved
@vsdkth vsdkth requested a review from belanglos March 4, 2024 10:59
@vsdkth vsdkth merged commit 490e003 into master Mar 4, 2024
3 checks passed
@vsdkth vsdkth deleted the issues/KUI-1226/antagning-button branch March 4, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belanglos belanglos Awaiting requested review from belanglos belanglos is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsdkth @belanglos