fix(KUI-1207): fix call to getCourseInfo

Only look at body if statusCode is 200/OK, otherwise return default values
KTH · Feb 29, 2024 · 0917e82 · 0917e82
1 parent e7d7bf5
commit 0917e82
Showing 1 changed file with 17 additions and 4 deletions.
diff --git a/server/apiCalls/kursinfoApi.js b/server/apiCalls/kursinfoApi.js
@@ -9,11 +9,24 @@ async function _getCourseInfo(courseCode) {
     const uri = client.resolve(paths.getCourseInfoByCourseCode.uri, { courseCode })
     const res = await client.getAsync({ uri }, { useCache: false })
 
-    if (res.body) {
-      const { sellingText, courseDisposition, supplementaryInfo, imageInfo } = res.body
-      return { sellingText, courseDisposition, supplementaryInfo, imageInfo }
+    const defaultValues = {
+      sellingText: { sv: '', en: '' },
+      imageInfo: '',
+      supplementaryInfo: { sv: '', en: '' },
+      courseDisposition: { sv: '', en: '' },
     }
-    return { sellingText: {}, imageInfo: '', supplementaryInfo: {}, courseDisposition: {} }
+
+    if (res.statusCode === 200 && res.body) {
+      const { body } = res
+      return {
+        sellingText: body.sellingText ?? defaultValues.sellingText,
+        courseDisposition: body.courseDisposition ?? defaultValues.courseDisposition,
+        supplementaryInfo: body.supplementaryInfo ?? defaultValues.supplementaryInfo,
+        imageInfo: body.imageInfo ?? defaultValues.imageInfo,
+      }
+    }
+
+    return defaultValues
   } catch (err) {
     log.error('Kursinfo-api is not available', err)
     return err