Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Reformat & Management #15

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Data Reformat & Management #15

wants to merge 4 commits into from

Conversation

KL13NT
Copy link
Owner

@KL13NT KL13NT commented Apr 6, 2021

Closes #13

KL13NT
KL13NT commented Apr 6, 2021
View reviewed changes
Copy link
Owner Author

@KL13NT KL13NT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the extension unless the user is updating or installing for the first time. Try adding another event, updateready that stops the tracker and the stores until an updatecomplete event is finished.

KL13NT
KL13NT commented Apr 7, 2021
View reviewed changes
Copy link
Owner Author

@KL13NT KL13NT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Need to test locally first tho.

@KL13NT KL13NT mentioned this pull request Apr 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor the data schema
1 participant
@KL13NT