Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI pipeline #929

Merged
merged 3 commits into from
Jan 13, 2025
Merged

fix: CI pipeline #929

merged 3 commits into from
Jan 13, 2025

Conversation

ntn-x2
Copy link
Member

@ntn-x2 ntn-x2 commented Jan 13, 2025

Disable compression for dependencies for reproducible install steps, and fix the CI issue with bundle test preparation.

Integration tests with develop are still broken since we have not yet released the updated type definitions.

@ntn-x2 ntn-x2 self-assigned this Jan 13, 2025
@ntn-x2 ntn-x2 changed the title fix: CI fix: CI pipeline Jan 13, 2025
@ntn-x2 ntn-x2 marked this pull request as ready for review January 13, 2025 12:45
@ntn-x2 ntn-x2 requested a review from rflechtner January 13, 2025 12:46
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I want to see if the CI still passes after the rebase, now that we merged the PR where we first noticed the playwright issue.

@ntn-x2
Copy link
Member Author

ntn-x2 commented Jan 13, 2025

@rflechtner yeah sorry I noticed I also merged with a lint error due to my autoformatting setting. I also fixed it in here now. I'll wait for the CI to turn green and red with the usual errors.

@ntn-x2
Copy link
Member Author

ntn-x2 commented Jan 13, 2025

Pipeline is now restored to what we expect. I'm merging it.

@ntn-x2 ntn-x2 merged commit 76f490e into develop Jan 13, 2025
12 of 14 checks passed
@ntn-x2 ntn-x2 deleted the aa/ci-fixes branch January 13, 2025 13:18
@rflechtner rflechtner mentioned this pull request Jan 16, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants