Tests with node16

[KristjanESPERANTO]

The tests will run with node 16, but they will fail. I think because the test-runner in node 16 is still in experimental state.

[KID-joker]

Maybe you are right and the problem lies with devDependecies.
So, you should call cli.mjs in test.js?

[KristjanESPERANTO]

So, you should call cli.mjs in test.js?

You are right. I've changed that.

Locally I got the tests not failing with node 16 (strange is that it says it's only one test). But in the GitHub action it fails now even with other versions 🤔

[KID-joker]

I exposed the APIs, so you can test them directly.

[KristjanESPERANTO]

I exposed the APIs, so you can test them directly.

Exposing the API is a good idea! Maybe someone wants to integrate the package into their project.

For using the API I think we should add new tests. So we have tests that test the cli and others that test the API.

Locally I got the tests not failing with node 16 (strange is that it says it's only one test). But in the GitHub action it fails now even with other versions 🤔

I did some digging but didn't get much further. locally the tests work in node 16 but fail in the gitHub action. I'm not giving up yet, but I don't know if I'll find much time for it.

[KID-joker]

I'm not giving up yet, but I don't know if I'll find much time for it.

Okay, I'll work with you. But it seems like you've already succeeded.

[KristjanESPERANTO]

Yes, it looks good now 🎉 Only one test does not work with node 16, I have deactivated this one test via if-condition. I sugggest to merge the PR and for the one test I create an issue and we take care of it afterwards.

[KID-joker]

Only one test does not work with node 16.

How did you get this result?
I tried running on node16 and it's fine.

[KID-joker]

And can you rewrite done into async/await?

[KristjanESPERANTO]

Only one test does not work with node 16.

How did you get this result?
I tried running on node16 and it's fine.

On my local machine npm run test works also with node 16, but not when it runs in the GitHub workflow.

Now it works because I deactivated the problematic test for node 16 via if (!process.version.startsWith('v16')) {.

[KristjanESPERANTO]

And can you rewrite done into async/await?

I don't think so. In my understanding the done() function is called once all asynchronous operations within the test have finished. Maybe there is a way, but I don't know.

[KID-joker]

Only one test does not work with node 16.

How did you get this result?
I tried running on node16 and it's fine.

On my local machine npm run test works also with node 16, but not when it runs in the GitHub workflow.

Now it works because I deactivated the problematic test for node 16 via if (!process.version.startsWith('v16')) {.

It seems that the installation failed because the request was deprecated.

[KristjanESPERANTO]

It seems that the installation failed because the request was deprecated.

Wow, at the beginning I thought we wouldn't get it to work with node 16. Nice job! 👏

[KID-joker]

It seems that the installation failed because the request was deprecated.

Wow, at the beginning I thought we wouldn't get it to work with node 16. Nice job! 👏

Everything is your help.