Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/firebase sdk #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature/firebase sdk #4

wants to merge 3 commits into from

Conversation

denis631
Copy link

@denis631 denis631 commented Jul 5, 2019

No description provided.

@denis631
- integrate new firebase admin sdk
bc26ef9 
- if Bearer → validate using Firebase
- if Basic → check the environment var
@denis631
- environment variable change
fdaab49
@denis631 denis631 requested review from cachapa and nithishr July 5, 2019 11:21
@denis631 denis631 self-assigned this Jul 5, 2019
@cachapa
Copy link

cachapa commented Jul 5, 2019

LGTM.
Please do not merge until we're ready to enforce authentication on the backend side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cachapa cachapa cachapa approved these changes

@nithishr nithishr Awaiting requested review from nithishr

Assignees

@denis631 denis631

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis631 @cachapa