Code readability Improvement #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emrewtc
suggested changes
Feb 9, 2018
| console.log('open called'); | ||
| gpio.open(pin, 'output', (err) => { // Open pin 11 for output | ||
| gpio.write(pin, 1, () => { // Set pin 11 high (1) | ||
| setTimeout(=> () { |
There was a problem hiding this comment.
setTimeout(=> () { seems like there's a syntax error here. Should have been like setTimeout( () => {
| @@ -1,7 +1,7 @@ | |||
| var http = require("http"); | |||
| var gpio = require("pi-gpio"); | |||
| var pin = 11; | |||
| var relayOpen = false; | |||
| let relayOpen = false; // A global flag for relay | |||
| var openTime = 2000; | |||
|
|
|||
There was a problem hiding this comment.
we might consider var pin = 11 and var openTime = 2000 can be const instead of var if they're not gonna change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I asked Rishat who is joining as our frontend lead engineer next month. He shared the updated code with me and I just replaced it in the
app.js.I think if we are publishing it to the world then it makes sense to ask for feedback and show the best version of our code :)
His comment and I am quoting:
Please test it first in production and see if there are no newly introduced bugs. If looks better than your code then I would say include this in the medium post and also a good learning for you then.