fix(controllers): do not reconcile status updates #233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR places an event filter when setting up that filters out updates to the status of all managed resources by this controller. We only want to reconcile the dashboards only if there's a change in the spec of the object, not the status.
I'm not 100% sure of myself but I suspect this creates an infinite loop of events: as it is, when the first reconciliation is done, dark sets the status to OK, which triggers another update and another reconciliation, and another status update... and so on and so forth 😅
Happy to chat about this.
Reference: kubernetes-sigs/kubebuilder#1103 and kubernetes-sigs/kubebuilder#618