-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LSMR further updates #111
Merged
Merged
LSMR further updates #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is one remaining todo (which could also be dealt with at a later time) and one interface questions:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #111 +/- ##
==========================================
+ Coverage 85.87% 86.16% +0.28%
==========================================
Files 30 32 +2
Lines 3286 3404 +118
==========================================
+ Hits 2822 2933 +111
- Misses 464 471 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@VictorVanthilt , this is based on your PR and contains an updated LSMR implementation. While it is quite different from the original implementation, your PR was still very helpful to finally push me to study and implement this. Major changes as compared to PR #109 :
krylovdim
steps, which cannot become very large. Furthermore, also restarting has the issue of the starting vector. The new implementation is almost exactly as discussed in the LSMR paper.linsolve
calls (no starting vector, a linear map for which also the adjoint needs to be defined, possibility to "regularise" the solution with a parameter lambda) I decided to move this to a separate (and thus new) function, calledlssolve
(for solving least squares problems).