Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: migrate to room gradle plugin #1627

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Conversation

BobbyESP
Copy link
Contributor

This commit updates the versioning logic. The toVersionCode function is also added to the Version class to calculate the version code based on the version components.

  • Added Room schemas folder creation when it doesn't exist
  • Updated deprecated code for the clean Gradle task

This commit updates the versioning logic. The `toVersionCode` function is also added to the `Version`
 class to calculate the version code based on the version components.
 - Added Room schemas folder creation when it doesn't exist
 - Updated deprecated code for the `clean` Gradle task
@JunkFood02
Copy link
Owner

Version codes are hardcoded for a reason, see #41 (comment)

But there's one thing we can migrate is to use Room gradle plugin instead of the current ksp arguments

@BobbyESP
Copy link
Contributor Author

Version codes are hardcoded for a reason, see #41 (comment)

But there's one thing we can migrate is to use Room gradle plugin instead of the current ksp arguments

Okayy, thanks for the info, and I'll do the Room thing

This commit updates various changes, including:
- Moved hardcoded version to version declaration (version.ref) for the androidx-compose-material3  dependency
- Adding Room plugin to the project and configuring schema directory
- Removing custom RoomSchemaArgProvider and using the built-in Room schema functionality
- Updating versionCode to 20000 due to F-droid requirements
This commit enables incremental annotation processing for Room using ksp.
 - Added `room.incremental`
 argument to ksp configuration.
 - Note that this is not yet supported by the Room plugin.
@BobbyESP
Copy link
Contributor Author

room.incremental seems not to be supported yet by the Room plugin, so I kept the ksp argument for the incremental but migrated the schema directory declaration to the plugin.

image

@BobbyESP
Copy link
Contributor Author

Ain't no way the CI fails because of not enough memory 💀

@JunkFood02 JunkFood02 changed the title refactor: Versioning system moved to project-level build.gradle.kts file build: migrate to room gradle plugin Aug 12, 2024
Copy link
Owner

@JunkFood02 JunkFood02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx!

@JunkFood02 JunkFood02 merged commit 8fbb8d6 into JunkFood02:main Aug 12, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants