Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual improvements #520

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Manual improvements #520

wants to merge 2 commits into from

Conversation

tyhlee
Copy link

@tyhlee tyhlee commented Mar 25, 2023

Mention independent/predictor variables and dependent/response variables at the same time at the top of the documentation.

Minor edits that do not change the context.

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.57 🎉

Comparison is base (b728917) 88.75% compared to head (0e77089) 89.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
+ Coverage   88.75%   89.32%   +0.57%     
==========================================
  Files           8        8              
  Lines        1040     1040              
==========================================
+ Hits          923      929       +6     
+ Misses        117      111       -6     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -22,14 +22,14 @@ Their arguments must be:
then a valid formula is `@formula(Y ~ X1 + X2)`
- `data`: a table in the Tables.jl definition, e.g. a data frame;
rows with `missing` values are ignored
- `X` a matrix holding values of the independent variable(s) in columns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so maybe also add features/target as this is a common term tuple in ML?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great suggestion, done 👍

@bkamins
Copy link
Contributor

bkamins commented Mar 26, 2023

Thank you. Let us wait for GLM.jl maintainers to comment.

@ayushpatnaikgit
Copy link
Contributor

@mousum-github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants