Resolve R2 Allocation test #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpo
reviewed
Dec 30, 2024
src/utils.jl
Outdated
| More specifically, construct a GenericExecutionStats on the NLPModel of reg_nlp and add three solver_specific entries namely :smooth_obj, :nonsmooth_obj and :xi. | ||
| This is useful for reducing the number of allocations when calling solve!(..., reg_nlp, stats) and should be used by default. | ||
| Warning: This should *not* be used when adding other solver_specific entries that do not have the current scalar type. | ||
| For instance, when one adds the history of the objective value as a solver_specific entry (which has Vector{T} type), this will cause an error and `GenericExecutionStats(reg_nlp.model)` should be used instead. |
There was a problem hiding this comment.
I think you can remove this sentence because history vectors should eventually be collected in the callback and not stored in stats.
| @@ -20,3 +24,20 @@ ShiftedProximalOperators.iprox!( | |||
|
|
|||
| LinearAlgebra.diag(op::AbstractDiagonalQuasiNewtonOperator) = copy(op.d) | |||
| LinearAlgebra.diag(op::SpectralGradient{T}) where {T} = zeros(T, op.nrow) .* op.d[1] | |||
|
|
|||
| """ | |||
| GenericExecutionStats(reg_nlp :: AbstractRegularizedNLPModel{T, V}) | |||
There was a problem hiding this comment.
We could give it a better name; that why I called GenericExecutionStats “generic” in the first place. Maybe RegularizedExecutionStats?!
| stats = GenericExecutionStats(reg_nlp.model, solver_specific = Dict{Symbol, T}()) | ||
| set_solver_specific!(stats, :smooth_obj, T(Inf)) | ||
| set_solver_specific!(stats, :nonsmooth_obj, T(Inf)) | ||
| set_solver_specific!(stats, :xi, T(Inf)) |
There was a problem hiding this comment.
I don't see how
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dpo @MohamedLaghdafHABIBOULLAH
I think this solves #161.
I added a function that constructs a
GenericExecutionStatson aRegularizedNLPModel.solver_specific entries are added during the construction, this removes the allocation in
solve!caused by adding an uninitialized solver_specific entry in stats.Also, for type stability, I had to specify that solver_specific entries are the same type as the one added in this new constructor, else there are allocations as well. This might cause issues if used without care.