Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semi-normal solvers #111

Merged
merged 14 commits into from
Jan 28, 2025

Conversation

MaxenceGollier
Copy link
Contributor

@MaxenceGollier MaxenceGollier commented Nov 26, 2024

#109
The next step would be to automatically call these functions in qrm_least_squares and qrm_min_norm when qrm_set(spfct, "qrm_keeph", 0) has been previously called.
I still have to figure out how to do it because spfct is not an argument of these functions.
Maybe add qrm_keeph :: String = 1 as a keyword argument ? Let me know what you think when you have some time !
@dpo, @amontoison

@amontoison
Copy link
Member

I suggest to add a keyword argument seminormal::Bool=false in the functions qrm_least_squares and qrm_min_norm.

@MaxenceGollier
Copy link
Contributor Author

Done in aa934fc.

@MaxenceGollier
Copy link
Contributor Author

What do you think of this now ? @amontoison
I will open a PR for a Golub-Riley implementation once this has been merged @dpo.

@amontoison
Copy link
Member

It's fine for me, Maxence.
Until I hear something from Dominique (such as an approval), I won’t merge the PR.
This way, it will avoid any overlap with what you are working on together.

src/QRMumps.jl Outdated Show resolved Hide resolved
src/QRMumps.jl Outdated Show resolved Hide resolved
src/QRMumps.jl Outdated Show resolved Hide resolved
src/QRMumps.jl Outdated Show resolved Hide resolved
src/QRMumps.jl Show resolved Hide resolved
src/QRMumps.jl Outdated Show resolved Hide resolved
src/utils.jl Show resolved Hide resolved
src/QRMumps.jl Outdated Show resolved Hide resolved
src/utils.jl Outdated Show resolved Hide resolved
src/wrapper/qr_mumps_api.jl Outdated Show resolved Hide resolved
Copy link
Member

@dpo dpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaxenceGollier !

@amontoison
Copy link
Member

@MaxenceGollier Can you rebase this PR?

test/test_qrm.jl Outdated Show resolved Hide resolved
@amontoison amontoison merged commit a9f7abe into JuliaSmoothOptimizers:main Jan 28, 2025
17 of 24 checks passed
@amontoison
Copy link
Member

Thanks @MaxenceGollier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants