Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add robot_arm_dynamics #175

Merged
merged 7 commits into from
Jun 1, 2022
Merged

Conversation

nathanemac
Copy link
Contributor

Add cops3 problem 8

src/ADNLPProblems/robot_arm_dynamics.jl Outdated Show resolved Hide resolved
src/ADNLPProblems/robot_arm_dynamics.jl Outdated Show resolved Hide resolved
src/ADNLPProblems/robot_arm_dynamics.jl Outdated Show resolved Hide resolved
src/ADNLPProblems/robot_arm_dynamics.jl Outdated Show resolved Hide resolved
src/ADNLPProblems/robot_arm_dynamics.jl Outdated Show resolved Hide resolved
src/ADNLPProblems/robot_arm_dynamics.jl Outdated Show resolved Hide resolved
src/Meta/robot_arm_dynamics.jl Outdated Show resolved Hide resolved
@tmigot
Copy link
Member

tmigot commented May 18, 2022

Thanks @nathanemac ! #161

Could you rename the robot_arm_dynamics by robotarm in all the files (and name of the files) ? So that we match the names in CUTEst.

@tmigot
Copy link
Member

tmigot commented May 18, 2022

And add the following comments at the beginning of the file with the model:

Minimize the time taken for a robot arm to travel between two points.

#  This is problem 8 in the COPS (Version 3) collection of 
#   E. Dolan and J. More
#   see "Benchmarking Optimization Software with COPS"
#   Argonne National Labs Technical Report ANL/MCS-246 (2004)

#  classification OOR2-AN-V-V

Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nathanemac ! Good job, I just have a couple of comments

src/Meta/robot_arm_dynamics.jl Outdated Show resolved Hide resolved
src/ADNLPProblems/robot_arm_dynamics.jl Outdated Show resolved Hide resolved
src/ADNLPProblems/robot_arm_dynamics.jl Outdated Show resolved Hide resolved
src/Meta/particles_distribution Outdated Show resolved Hide resolved
src/ADNLPProblems/particles_distribution.jl Outdated Show resolved Hide resolved
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nathanemac ! Another batch of comment, I checked the whole model also, and it looks good to me.

src/ADNLPProblems/robotarm.jl Outdated Show resolved Hide resolved
src/ADNLPProblems/robotarm.jl Outdated Show resolved Hide resolved
src/ADNLPProblems/robotarm.jl Outdated Show resolved Hide resolved
src/ADNLPProblems/robotarm.jl Outdated Show resolved Hide resolved
src/ADNLPProblems/robotarm.jl Show resolved Hide resolved
src/ADNLPProblems/robotarm.jl Outdated Show resolved Hide resolved
src/ADNLPProblems/robotarm.jl Outdated Show resolved Hide resolved
src/ADNLPProblems/robotarm.jl Outdated Show resolved Hide resolved
src/ADNLPProblems/robotarm.jl Outdated Show resolved Hide resolved
src/ADNLPProblems/robotarm.jl Outdated Show resolved Hide resolved
src/ADNLPProblems/robotarm.jl Show resolved Hide resolved
src/ADNLPProblems/robotarm.jl Outdated Show resolved Hide resolved
src/ADNLPProblems/robotarm.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #175 (6763a12) into main (594dad3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #175   +/-   ##
=======================================
  Coverage   99.88%   99.89%           
=======================================
  Files         718      721    +3     
  Lines        6281     6364   +83     
=======================================
+ Hits         6274     6357   +83     
  Misses          7        7           
Impacted Files Coverage Δ
src/ADNLPProblems/robotarm.jl 100.00% <100.00%> (ø)
src/Meta/robotarm.jl 100.00% <100.00%> (ø)
src/PureJuMP/robotarm.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 594dad3...6763a12. Read the comment docs.

Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @nathanemac !

I completed the files with some details.

@tmigot tmigot merged commit dbfa225 into JuliaSmoothOptimizers:main Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants