Fixed Expr issue when the ci is a type of GlobalRef #545
Merged
chriselrod merged 1 commit intoJuliaSIMD:mainfrom Mar 27, 2025
Merged
Fixed Expr issue when the ci is a type of GlobalRef #545chriselrod merged 1 commit intoJuliaSIMD:mainfrom
chriselrod merged 1 commit intoJuliaSIMD:mainfrom
Conversation
Member
|
Mind adding a test that fails without this change but passes with it? |
Contributor
Author
|
It requires Llama2 to be installed. https://github.com/cafaxo/Llama2.jl Here is the test. It gives below error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error handling if the ci is of type GlobalRef, from which the Expr can be constructed. It also have error handling if the Ci is a different type.