[Singular_jll] yank some breaking releases #120133
Open
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
approved these changes
Nov 25, 2024
|
In the meantime we also merged JuliaPackaging/Yggdrasil#9864 which should also solve the problem, so perhaps we don't need this after all (though I was the one requesting this -- apologies to @lgoettgens :-/ ). The background there is that from a technical POV yanking these "feels" right as these versions are really broken in various ways (the last one the least, it "only" causes doctest failures). So anyone using them will run into problems; but of course once the new JLL version lands nobody should ever get these unless they explicitly specify the version (which makes it their own fault), or if they had the misfortune of updating in the last couple days (but then running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
404.0.707+0release was faulty, the following ones tried to fix that, but unfortunately, they were still breaking downstream (cf oscar-system/Oscar.jl#4341), although marked as a patch release.oscar-system/Oscar.jl#4341 will take care of releasing the previous working version as another new patch release, but nevertheless it would be good to get these versions out of the resolvers options.
ping @fingolfin @benlorenz @thofma