-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upate readme on yanking and version changes #106278
Conversation
Co-authored-by: Felix Cremer <[email protected]>
Some comments from @StefanKarpinski on slack regarding the current permissable context for yanking:
And in response to: "But the readmes for general registry and ColPrac still both say to yank if you register a version with too wide compat bounds"
|
Ah so those guidelines are recently added. That is somewhat confusing as they are not really in line with discussions on slack. |
IMO if we are going to suggest manual changes to compat bounds, we need reviewers who are able and willing to review/merge. Maybe we have that? Not really sure, those PRs tend to linger for awhile I think |
e.g. #85431 |
This was merged when it passed: |
These seem to mostly get merged the same day? They also seem to be nearly 100% merged by @giordano . It would be good to hear your thoughts here Mosè, I'm mostly trying to update the guidlines to match your advice in PRs. |
This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock] |
This pull request has been inactive for more than 30 days and has automatically been closed. Feel free to register your package or version again once you fix the AutoMerge issues. [noblock] |
This PR is a response to yanking being highly discouraged these days, but still suggested in the README.
I've attempted to start to outline the alternative but input would be appreciated.