Support Julia 1.7 #457
Merged
Support Julia 1.7 #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
==========================================
- Coverage 89.05% 88.92% -0.13%
==========================================
Files 39 39
Lines 2247 2257 +10
==========================================
+ Hits 2001 2007 +6
- Misses 246 250 +4
Continue to review full report at Codecov.
|
tkf
commented
Oct 24, 2021
Comment on lines
+236
to
240
| # Using this workaround for Julia >= 1.6 in macOS for now: | ||
| # https://github.com/JuliaLang/julia/issues/40246 | ||
| cwd = os.getcwd() | ||
| try: | ||
| os.chdir(os.path.dirname(self.libjulia_path)) |
There was a problem hiding this comment.
This reverts commit 2c6fbe9.
mkitti
reviewed
Oct 25, 2021
| @@ -31,8 +31,13 @@ | |||
|
|
|||
| def setup_libjulia(libjulia): | |||
| # Store the running interpreter reference so we can start using it via self.call | |||
There was a problem hiding this comment.
The line that this comment, "Store the running interpreter reference...", to has been gone for a long time.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #455
close #454