Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass at a
DateRangePicker
as described in #255.To see it in action, open the
src/DateRangePicker.jl
notebook.I wanted something that behaved like this:
It's not fully working yet. I have used
transformed_value
, as in ScrubbableMatrix, to build aDateRangePicker
out of twoDatePicker
s. But this causes problems when the range isn't valid (e.g. if no default range is set). There are some assertions for validation in the inner function of transformed_value, but transformed_value turns these into its own error tuple, which bubbles up to the bound value itself. So a defaultDateRangePicker()
returns an error tuple instead ofnothing
, which doesn't feel right to me:The error logging above also doesn't disappear when a correct range is entered. I'll experiment; maybe I need to log an
@error
and return nothing instead of using@assert
in the inner function.Addresses #255