Skip to content

Commit

Permalink
remove Base.vect overload
Browse files Browse the repository at this point in the history
  • Loading branch information
sglyon authored Jul 16, 2021
1 parent 4a9e1ad commit 3d58692
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 7 deletions.
10 changes: 10 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// For format details, see https://aka.ms/devcontainer.json. For config options, see the README at:
// https://github.com/microsoft/vscode-dev-containers/tree/v0.187.0/containers/julia
// See https://github.com/julia-vscode/julia-devcontainer/blob/master/Dockerfile for image contents
{
"name": "Julia (Community)",
"image": "ghcr.io/julia-vscode/julia-devcontainer",
"extensions": ["julialang.language-julia"],
"postCreateCommand": "/julia-devcontainer-scripts/postcreate.jl",
"remoteUser": "vscode"
}
6 changes: 3 additions & 3 deletions Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "PlotlyJS"
uuid = "f0f68f2c-4968-5e81-91da-67840de0976a"
authors = ["Spencer Lyon <[email protected]>"]
version = "0.16.4"
version = "0.17.0"

[deps]
Blink = "ad839575-38b3-5650-b840-f874b8c74a25"
Expand All @@ -20,11 +20,11 @@ WebIO = "0f1e0344-ec1d-5b48-a673-e5cf874b6c29"
Blink = "0.12"
JSExpr = "0.5"
JSON = "0.20, 0.21"
PlotlyBase = "0.6"
PlotlyBase = "0.6, 0.7"
Reexport = "0.2, 1"
Requires = "1.0"
WebIO = "0.8"
julia = "1.3, 1.4, 1.5"
julia = "1.3, 1.4, 1.5, 1.6"

[extras]
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Expand Down
7 changes: 3 additions & 4 deletions src/util.jl
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@ JSON.lower(sp::SyncPlot) = sp.plot
PlotlyBase._is3d(p::SyncPlot) = _is3d(p.plot)

# subplot methods on syncplot
Base.hcat(sps::SyncPlot...) = SyncPlot(hcat([sp.plot for sp in sps]...))
Base.vcat(sps::SyncPlot...) = SyncPlot(vcat([sp.plot for sp in sps]...))
Base.vect(sps::SyncPlot...) = vcat(sps...)
Base.hcat(sps::SyncPlot...) = SyncPlot(hcat(Plot[sp.plot for sp in sps]...))
Base.vcat(sps::SyncPlot...) = SyncPlot(vcat(Plot[sp.plot for sp in sps]...))
Base.hvcat(rows::Tuple{Vararg{Int}}, sps::SyncPlot...) =
SyncPlot(hvcat(rows, [sp.plot for sp in sps]...))
SyncPlot(hvcat(rows, Plot[sp.plot for sp in sps]...))

function PlotlyBase.add_recession_bands!(p::SyncPlot; kwargs...)
new_shapes = add_recession_bands!(p.plot; kwargs...)
Expand Down

2 comments on commit 3d58692

@sglyon
Copy link
Member Author

@sglyon sglyon commented on 3d58692 Jul 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/41004

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.17.0 -m "<description of version>" 3d586922b21617e80f66ca51237ce5ba28134252
git push origin v0.17.0

Please sign in to comment.