Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LAPACK 3.11.0 #6719

Merged
merged 1 commit into from
May 9, 2023
Merged

LAPACK 3.11.0 #6719

merged 1 commit into from
May 9, 2023

Conversation

ViralBShah
Copy link
Member

Continuation from #6553

@ViralBShah ViralBShah requested review from giordano and amontoison May 7, 2023 02:27
giordano
giordano reviewed May 7, 2023
View reviewed changes
L/LAPACK/common.jl Show resolved Hide resolved
L/LAPACK/common.jl Show resolved Hide resolved
@ViralBShah ViralBShah force-pushed the vs/lapack311-2 branch 2 times, most recently from a5192ee to ab91573 Compare May 7, 2023 15:11
@ViralBShah
Copy link
Member Author

ViralBShah commented May 8, 2023 •
edited
Loading

Can we use Julia 1.9 as the conpat version here and hence LBT 5.4?

Cc @amontoison

@ViralBShah
Copy link
Member Author

ViralBShah commented May 8, 2023 •
edited
Loading

1.9.1 is going to have LBT 5.8. I suppose the only lever of control we have here is which version of Julia to use. JuliaLang/julia#49680

I feel that Julia 1.9 is the right compat to define.

@ViralBShah
Copy link
Member Author

@giordano ok to merge?

@amontoison
Copy link
Contributor

1.9.1 is going to have LBT 5.8. I suppose the only lever of control we have here is which version of Julia to use. JuliaLang/julia#49680

I feel that Julia 1.9 is the right compat to define.

Oh, I suppose that you can use LBT 5.7.0 in Julia 1.9 because you compile it from sources when you build Julia.
We are unable to compile an artifact here with LBT 5.7.0 directly because the compat entry of LBT_jll is 1.10 but that's fine to link with LBT 5.4.0 because it's compatible with versions of LBT in [5.4.0, 6.0.0[.

amontoison
amontoison reviewed May 9, 2023
View reviewed changes
L/LAPACK/common.jl Outdated Show resolved Hide resolved
@ViralBShah ViralBShah closed this May 9, 2023
@ViralBShah ViralBShah reopened this May 9, 2023
@ViralBShah @amontoison
LAPACK 3.11.0 - Continuation of #6553
cddf51a 
Do not use -cpp and -DUSE_ISNAN on 32-bit platforms
Avoid libgfortran4 builds on aarch64 linux for LAPACK_jll

Co-authored-by: Alexis Montoison <[email protected]>
@ViralBShah ViralBShah merged commit c9f9e28 into master May 9, 2023
@ViralBShah ViralBShah deleted the vs/lapack311-2 branch May 9, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amontoison amontoison amontoison left review comments

@giordano giordano giordano left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ViralBShah @amontoison @giordano