Write Project.toml with the same section sorting as Pkg#74
Write Project.toml with the same section sorting as Pkg#74nickrobinson251 wants to merge 3 commits intoJuliaPackaging:masterfrom
Conversation
|
this would be nice to have. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #74 +/- ##
=========================================
Coverage ? 93.10%
=========================================
Files ? 2
Lines ? 174
Branches ? 0
=========================================
Hits ? 162
Misses ? 12
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fingolfin
left a comment
fingolfin
left a comment
There was a problem hiding this comment.
Looks good to me but would indeed be great if @KristofferC could comment
| # Taken from Pkg.jl v1.11.4 (but we don't want to depend on Pkg.jl directly just for this) | ||
| # https://github.com/JuliaLang/Pkg.jl/blob/v1.11.4/src/project.jl#L235 | ||
| # with `preferences` added before `deps` | ||
| const _project_key_order = ["name", "uuid", "keywords", "license", "desc", "preferences", "deps", "weakdeps", "sources", "extensions", "compat"] |
There was a problem hiding this comment.
If we insert preferences here, should a similar patch be made to Pkg.jl so that it also sorts preferences to the same position?
| if VERSION > v"1.11.0-" | ||
| @testset "Project.toml writing" begin | ||
| Pkg.activate("PkgV_1_11_plus") do | ||
| @eval using PkgV_1_11_plus |
There was a problem hiding this comment.
This code suffers from world age issues, hence the tests are failing with Julia >= 1.12
See also my PR #88 which might give a suggestion how to fix this (but perhaps a better solution is possible)
4 participants
close #52
Let me know:
preferencessection... up near the top made sense to me... could also be at the bottom ofc, someone just got to pick