use shorter extension names #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jw3126
reviewed
Jan 8, 2025
Comment on lines
19
to
23
| if !isdefined(Base, :get_extension) | ||
| include("../ext/AccessorsDatesExt.jl") | ||
| include("../ext/AccessorsLinearAlgebraExt.jl") | ||
| include("../ext/AccessorsTestExt.jl") | ||
| include("../ext/DatesExt.jl") | ||
| include("../ext/LinearAlgebraExt.jl") | ||
| include("../ext/TestExt.jl") | ||
| end |
There was a problem hiding this comment.
Not this PR. But what do you think about bumping julia version to the current LTS 1.10 and getting rid of Requires and other legacy compat?
There was a problem hiding this comment.
Yes, can easily be done now that it's the lts!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shorter names have been recommended for quite some time already, see https://pkgdocs.julialang.org/v1/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions). Actually, there was only a short period of time early during 1.9 version, when some tooling didn't work with these shorter names. Now, they only serve to clutter precompilation output :)