Merge pull request #39 from JuliaManifolds/mbaran/vector-transport-tr…

…ansparency vector_transport_direction! should be :parent (it has a fallback)
JuliaManifolds · Apr 28, 2020 · 7a38c6e · 7a38c6e · mateuszbaran · Apr 28, 2020
2 parents 9563257 + e5c98ba
commit 7a38c6e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "ManifoldsBase"
 uuid = "3362f125-f0bb-47a3-aa74-596ffd7ef2fb"
 authors = ["Seth Axen <[email protected]>", "Mateusz Baran <[email protected]>", "Ronny Bergmann <[email protected]>", "Antoine Levitt <[email protected]>"]
-version = "0.8.2"
+version = "0.8.3"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

diff --git a/src/EmbeddedManifold.jl b/src/EmbeddedManifold.jl
@@ -486,7 +486,7 @@ function decorator_transparent_dispatch(
     ::AbstractEmbeddedManifold,
     args...,
 )
-    return Val(:intransparent)
+    return Val(:parent)
 end
 function decorator_transparent_dispatch(
     ::typeof(vector_transport_direction!),

diff --git a/test/embedded_manifold.jl b/test/embedded_manifold.jl
@@ -139,9 +139,10 @@ struct NotImplementedEmbeddedManifold3 <: AbstractEmbeddedManifold{ℝ,DefaultEm
         for f in [log!, norm, manifold_dimension, project!]
             @test ManifoldsBase.decorator_transparent_dispatch(f,AM) === Val{:intransparent}()
         end
-        for f in [vector_transport_along!, vector_transport_direction!, vector_transport_to!]
+        for f in [vector_transport_along!, vector_transport_to!]
             @test ManifoldsBase.decorator_transparent_dispatch(f,AM) === Val{:intransparent}()
         end
+        @test ManifoldsBase.decorator_transparent_dispatch(vector_transport_direction!, AM) === Val{:parent}()
 
         for f in [inner, norm]
             @test ManifoldsBase.decorator_transparent_dispatch(f,IM) === Val{:transparent}()