Hide unsafe constructors of IOStream #58023
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsajko
approved these changes
Apr 6, 2025
Member
nsajko
left a comment
nsajko
left a comment
There was a problem hiding this comment.
It seems no package uses the deleted constructor methods:
Member
Author
|
@nsajko Looks to me like some packages ARE using it: https://juliahub.com/ui/Search?type=code&q=IOStream(%22 |
Member
Author
|
I think I need to figure out what on Earth |
Member
|
Perhaps remove the two-arg methods in this PR (those seem unused among the packages), leaving the single-arg method for a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58021