Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use faster timeout on cmdlineargs test that relies on timeout #57164

Merged

Conversation

IanButterworth
Copy link
Member

Otherwise this test takes 1 minute doing nothing before the worker times out and satisfies the error throw.
i.e. locally

julia> run(`$(Base.julia_cmd()) --worker=true`)
julia_worker:9616#192.168.12.246
Master process (id 1) could not connect within 60.0 seconds.
exiting.
julia> withenv("JULIA_WORKER_TIMEOUT" => "5") do
       run(`$(Base.julia_cmd()) --worker=true`)
       end
julia_worker:9708#192.168.12.246
Master process (id 1) could not connect within 5.0 seconds.
exiting.

@vtjnash
Copy link
Member

vtjnash commented Jan 27, 2025

It may need to slightly longer to be an accurate test, since some CI is slow and there is a sleep(2) in the worker code before they finish connecting that adds even delay to a normally functioning launch

test/cmdlineargs.jl Outdated Show resolved Hide resolved
@IanButterworth IanButterworth added the merge me PR is reviewed. Merge when all tests are passing label Jan 27, 2025
@IanButterworth IanButterworth merged commit 779b750 into JuliaLang:master Jan 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me PR is reviewed. Merge when all tests are passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants