complete the tests for Compiler.jl as the stdlib. #56648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
reviewed
Nov 22, 2024
Keno
approved these changes
Nov 22, 2024
With #56632, Compiler.jl as the stdlib can now be tested. However, the PR was incomplete, and when tests are actually run on `Compiler`, which is `!== Base.Compiler`, various errors occur, including issues caused by #56647. This commit resolves all these issues: - manage the code for loading `Compiler` in `setup_Compiler.jl`, ensuring that the stdlib version of `Compiler` is loaded when `@activate Compiler` is used beforehand - replace `Base.IRShow` with `Compiler.IRShow` - test `Base.Compiler.return_type` instead of `Compiler.return_type` This was split off from #56636.
aviatesk
force-pushed
the
avi/fix-compilertests
branch
from
956549a to
fa6ad79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #56632, Compiler.jl as the stdlib can now be tested. However, the PR was incomplete, and when tests are actually run on
Compiler, which is!== Base.Compiler, various errors occur, including issues caused by #56647.This commit resolves all these issues:
Compilerinsetup_Compiler.jl, ensuring that the stdlib version ofCompileris loaded when@activate Compileris used beforehandBase.IRShowwithCompiler.IRShowBase.Compiler.return_typeinstead ofCompiler.return_typeThis was split off from #56636.