threading deadlock: change jl_fptr_wait_for_compiled to actually compile code #56571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbaraldi
approved these changes
Nov 15, 2024
|
LGTM with analyze GC happier |
vtjnash
force-pushed
the
jn/wait_for_compiled-deadlock
branch
from
1f3fcde to
6c458db
Compare
…ile code
The jl_fptr_wait_for_compiled state merely means it could compile that
code, but in many circumstances, it will not actually compile that code
until a long delay: when either all edges are satisfied or it is
demanded to run immediately. The previous logic did not handle that
possibility leading to deadlocks (possible even on one thread).
A high rate of failure was shown on running the following CI test:
$ ./julia -t 20 -q <<EOF
for i = 1:1000
i % 10 == 0 && @show i
(@eval function _atthreads_greedy_dynamic_schedule()
inc = Threads.Atomic{Int}(0)
Threads.@threads :greedy for _ = 1:Threads.threadpoolsize()
Threads.@threads :dynamic for _ = 1:Threads.threadpoolsize()
Threads.atomic_add!(inc, 1)
end
end
return inc[]
end)() == Threads.threadpoolsize() * Threads.threadpoolsize()
end
EOF
vtjnash
force-pushed
the
jn/wait_for_compiled-deadlock
branch
from
6c458db to
1d331d1
Compare
oscardssmith
added
multithreading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jl_fptr_wait_for_compiled state merely means it could compile that code, but in many circumstances, it will not actually compile that code until a long delay: when either all edges are satisfied or it is demanded to run immediately. The previous logic did not handle that possibility leading to deadlocks (possible even on one thread).
A high rate of failure was shown on running the following CI test: