Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing convert methods for Cholesky #56562

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Add missing convert methods for Cholesky #56562

merged 2 commits into from
Nov 19, 2024

Conversation

timholy
Copy link
Member

@timholy timholy commented Nov 14, 2024

No description provided.

@kshyatt kshyatt added the linear algebra Linear algebra label Nov 15, 2024
@dkarrasch
Copy link
Member

This is usually done by relying on generic convert methods and overloading the constructors instead. That's also why we then don't need to handle the noop case.

@dkarrasch
Copy link
Member

Similar conversion methods seem to be missing for most other factorizations, so this looks like a little "project". ;-)

Also, I didn't write out all the conversions, because they are handled by the inner constructor, once all type parameters are specified.

@dkarrasch dkarrasch merged commit 0bd8292 into master Nov 19, 2024
4 of 7 checks passed
@dkarrasch dkarrasch deleted the teh/chol_convert branch November 19, 2024 16:09
@timholy
Copy link
Member Author

timholy commented Nov 21, 2024

Thanks @dkarrasch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants