Sockets: fix getipaddr()
#56528
Merged
Sockets: fix getipaddr()
#56528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIUC, the current behavior was deliberately chosen in #30609 to avoid breakage in code that has problems with IPv6. Not sure that's a valid concern still. That said, isn't -getipaddr() = getipaddr(IPv4)
+getipaddr() = getipaddr(IPAddr)all that's needed as a change here? |
|
Thank you for your input. I would have never guessed that So is it correct that the whole |
I think so, yes. |
This PR updates the definition of `getipaddr()` so that the documentation is respected. Before this change, `getipaddr()` would throw an error unless there is an `IPv4` address assigned to a network interface. After this change, `getipaddr()` preferably returns an `IPv4` address, but if none exists, it returns an `IPv6` address. Fixes JuliaLang#56520
barucden
changed the title
getipaddr(), simplify getipaddr(T)getipaddr()
vtjnash
reviewed
Nov 14, 2024
|
Yes, looks like the findfirst logic was added with the intent of making this work this way, but forgot to make the change to getipaddr (#32179 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the definition of
getipaddr()so that the documentation is respected.Before this change,
getipaddr()would throw an error unless there is anIPv4address assigned to a network interface. After this change,getipaddr()preferably returns anIPv4address, but if none exists, it returns anIPv6address.Fixes #56520