Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compiler tests to Compiler package #56522

Merged
merged 7 commits into from
Nov 12, 2024
Merged

Move compiler tests to Compiler package #56522

merged 7 commits into from
Nov 12, 2024

Conversation

Keno
Copy link
Member

@Keno Keno commented Nov 11, 2024

This does not yet make the compiler tests independently runnable using ] test Compiler; it only moves the files and wires them up to continue running as part of the Base test runner.

Keno and others added 4 commits November 11, 2024 16:45
This does not yet make the compiler tests independently runnable
using `] test Compiler`; it only moves the files and wires them
up to continue running as part of the Base test runner.
@KristofferC
Copy link
Member

To make them runnable from Pkg we only need to add a runtests.jl file as well as a https://github.com/JuliaLang/julia/blob/master/stdlib/LinearAlgebra/test/testgroups file so that when Base CI run this are run in parallel? It is a bit unfortunate that test Compiler will run them serially but there is no built in support for running package tests in parallel.

@Keno
Copy link
Member Author

Keno commented Nov 12, 2024

Yes, this PR does add those files. The parallel running is an issue, but the bigger issue right now is that a test Compiler will test Base.Compiler, not the package version. This needs a larger adjustment to each test, which will be in a follow up PR.

@Keno Keno merged commit 45c5c9b into master Nov 12, 2024
4 of 7 checks passed
@Keno Keno deleted the kf/mvcompilertests branch November 12, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants