precompile: do better union split and concrete compilation search #56496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
force-pushed
the
jn/more-precompile+all
branch
from
79bea13 to
7ed179b
Compare
|
The sysimage size is quite significant... There are no benchmarks and no tests that justify this yet, so adding those might make it more palatable. |
vtjnash
force-pushed
the
jn/more-precompile+all
branch
from
7ed179b to
b026ab6
Compare
This could previously cause any use of llvmcall to crash during ji generate or generate bad code. Now it uses the llvm attribute to specify this correctly.
vtjnash
force-pushed
the
jn/more-precompile+all
branch
from
b026ab6 to
882f940
Compare
|
I have some thoughts about improving system image size, but they don't involve being worse at choosing what code to compile as we are without this PR |
|
I'm inclined to agree with @vtjnash - this isn't really a policy change on what code to keep as much as it's a bugfix for all the code we weren't intending to delete / not compile I think it's probably worth taking the hit to have a coherent caching policy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some bugs that prevent compile-all from working correctly at all, and uses more of it for normal compile. Increases sysimg size from about 140 to 170 MB of data and 11 to 15 MB of code