Refactor julia initialization to behave better when used as a dylib #56334
+144
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing embedding julia as a shared library behave better
gbaraldi
force-pushed
the
gb/refactor-juliac-init
branch
from
2f6a6c4 to
34fe416
Compare
topolarity
reviewed
Dec 17, 2024
| // This code path assumes that you are either an executable or dylib with the sysimage linked in | ||
| jl_base_image_handle = sysimg_handle; | ||
| julia_init(JL_IMAGE_IN_MEMORY); | ||
| jl_enter_threaded_region(); |
There was a problem hiding this comment.
It looks like it's possible for code (on another thread) to start executing before we enter_threaded_region here
I assume that it's OK for us to enter the region after-the-fact, and that will still allow any IO to eventually be scheduled?
topolarity
reviewed
Dec 17, 2024
|
|
||
| // Should be called in an attribute constructor function to make initialization threadsafe when embedding as an SO. |
There was a problem hiding this comment.
What does this comment mean? This is an __attribute__((constructor))
topolarity
reviewed
Dec 17, 2024
Comment on lines
1090
to
+1091
| julia_init(jl_options.image_file_specified ? JL_IMAGE_CWD : JL_IMAGE_JULIA_HOME); | ||
| jl_atomic_store_release(&jl_runtime_is_initialized, 1); |
There was a problem hiding this comment.
Should this be set by julia_init instead?
It seems like embedding applications might call that directly
topolarity
reviewed
Dec 17, 2024
| XSTR(jl_find_dynamic_library_by_addr), M); | ||
| } | ||
| auto this_func = builder.GetInsertBlock()->getParent(); | ||
| handle = builder.CreateCall(dladdr, {ConstantExpr::getBitCast(this_func, builder.getPtrTy())}); |
There was a problem hiding this comment.
Do we ever use this in pkgimages?
It seem like it will get the wrong handle in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The big changes are moving initialization to when someone calls into julia, making it all automatic. (It still supports manually initializing the runtime). I'm not done with this because i still need to figure out how to embed runtime arguments. Currently it's piped as a string but it's not clear yet if that's the best way forward.
We maybe want to make the changes to adopt thread handling only exist behind a flag. Though that potentially doesn't add much because essentially this adds a very predictable null check to ccallable