Revert "Extensions: make loading of extensions independent of what packages are in the sysimage (#52841) #56234
+24
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
added
backport 1.10
KristofferC
force-pushed
the
kc/revert_sysimnage_ext
branch
from
c19c9fe
to
ad1dc39
Compare
topolarity
approved these changes
Oct 21, 2024
topolarity
reviewed
Oct 21, 2024
| @@ -974,14 +974,14 @@ function explicit_manifest_deps_get(project_file::String, where::PkgId, name::St | |||
| entry = entry::Dict{String, Any} | |||
| uuid = get(entry, "uuid", nothing)::Union{String, Nothing} | |||
| uuid === nothing && continue | |||
| # deps is either a list of names (deps = ["DepA", "DepB"]) or | |||
| # a table of entries (deps = {"DepA" = "6ea...", "DepB" = "55d..."} | |||
| deps = get(entry, "deps", nothing)::Union{Vector{String}, Dict{String, Any}, Nothing} | |||
There was a problem hiding this comment.
Is this deps lookup fix related? Does it need a test to match?
There was a problem hiding this comment.
It is partly related since this runs into #55939 due to how the manifest change with the revert. So it does in some sense already has a test.
This was referenced Oct 29, 2024
This was referenced Nov 22, 2024
topolarity
added a commit
that referenced
this pull request
Nov 22, 2024
|
@KristofferC We don't need any of this on 1.10, right? I believe we merged an equivalent to ad1dc39 at some point, but wanted to double check edit: Ah yep, that was 385caed - I'm going to remove the backport label since I think we got everything here. |
topolarity
removed
the
backport 1.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 08d229f.
There are some bugs now where extensions do not load when their package has been put into the sysimage. #52841 was made because it was common to get cycles otherwise but with #55589 that should be much less of a problem.
Subsumes #54750.