Restore some ABI compatibility with Julia 1.6 #40851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Julia <= 1.6, the C API function `jl_init` and `jl_init_with_image` were exported on the ABI level under the names `jl_init__threading` and `jl_init_with_image__threading`. This was changed during development of Julia 1.7, but unfortunately that broke ABI compatibility with binaries build against Julia <= 1.6. Add back and export two simple wrapper functions to restore this aspect of ABI compatibility. This way, people gain some time to migrate existing code bases, and have an easier time supporting both released Julia versions and nightly Julia builds. Once Julia 1.7 is out, which exports both the old and new symbol names, these wrappers could be removed for Julia 1.8 development (or they could also be left in, given that they don't seem to cost us anything?)
JeffBezanson
approved these changes
May 18, 2021
shirodkara
pushed a commit
to shirodkara/julia
that referenced
this pull request
Jun 9, 2021
In Julia <= 1.6, the C API function `jl_init` and `jl_init_with_image` were exported on the ABI level under the names `jl_init__threading` and `jl_init_with_image__threading`. This was changed during development of Julia 1.7, but unfortunately that broke ABI compatibility with binaries build against Julia <= 1.6. Add back and export two simple wrapper functions to restore this aspect of ABI compatibility.
|
Is it possible to install a version of julia with this patch? |
KristofferC
added
backport 1.6
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
In Julia <= 1.6, the C API function `jl_init` and `jl_init_with_image` were exported on the ABI level under the names `jl_init__threading` and `jl_init_with_image__threading`. This was changed during development of Julia 1.7, but unfortunately that broke ABI compatibility with binaries build against Julia <= 1.6. Add back and export two simple wrapper functions to restore this aspect of ABI compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Julia <= 1.6, the C API function
jl_initandjl_init_with_imagewereexported on the ABI level under the names
jl_init__threadingandjl_init_with_image__threading. This was changed during development of Julia1.7, but unfortunately that broke ABI compatibility with binaries build
against Julia <= 1.6.
Add back and export two simple wrapper functions to restore this aspect of ABI
compatibility. This way, people gain some time to migrate existing code bases,
and have an easier time supporting both released Julia versions and nightly
Julia builds.
Once Julia 1.7 is out, which exports both the old and new symbol names, these
wrappers could be removed for Julia 1.8 development (or they could also be
left in, given that they don't seem to cost us anything?)
Resolves #40730
Resolves oscar-system/GAP.jl#646
Might help (partially?) with issue #40246.