Correct ANSI printing of alternating bold/dim #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way that bold/dim work in TTYs is a little weird. They're two channels of information (text can be bold and dim, just one, or either), but also sort of one channel of information (weight). Dim can also be a light font weight, which is how we frame/interpret it here. To avoid unexpected behaviour, we clear the bold/dim status before re-setting it when changing between the two.
tecosaur
force-pushed
the
fix-bold-dim-print
branch
from
35a2607 to
04abf3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way that bold/dim work in TTYs is a little weird. They're two channels of information (text can be bold and dim, just one, or either), but also sort of one channel of information (weight). Dim can also be a light font weight, which is how we frame/interpret it here. To avoid unexpected behaviour, we clear the bold/dim status before re-setting it when changing between the two.